Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump #165

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Bump #165

merged 4 commits into from
Jul 10, 2024

Conversation

MaeIsBad
Copy link
Member

No description provided.

@MaeIsBad MaeIsBad requested a review from a team as a code owner July 10, 2024 07:51
cpiemontese
cpiemontese previously approved these changes Jul 10, 2024
CHANGELOG.md Outdated
### Security

- Switched to using XChaCha20Poly1305 for the redis token cache encryption.

This addresses a few medium severity security issues with the tokens
This addresses a few medium severity security issues with the tokens. Note that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this imply a breaking change...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't say so. You can't use previous versions of the library alongside the new one, but you can upgrade without any changes on your end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, although I agree with Simone's comment below

Copy link
Member

@cottinisimone cottinisimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People might be scared about the token cache is incompatible with old versions of the library is it worth it to explain that this will result only in more calls to auth0/okta?

@MaeIsBad
Copy link
Member Author

@cottinisimone how do you feel about this? I tried rewording it a little

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Simone Cottini <cottini.simone@gmail.com>
@MaeIsBad MaeIsBad merged commit 769f953 into master Jul 10, 2024
7 checks passed
@MaeIsBad MaeIsBad deleted the bump branch July 10, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants