Fix #6371: Add node and expanded data on nodetoggleicon. #6372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Nodetoggleicon slot is used to customize expand / collapse and loading icon, but when loading mode is set to icon mode and a node is loading, TreeNode use nodetoggleicon without any props instead of binding node and expanded. This commit bind node and expanded props to nodetoggleicon slot when loading mode is set to icon and node.loading is true.
mehdirande
force-pushed
the
fix-6371-add-slots-data-on-tree-nodetoggleicon
branch
from
31e2ddf
to
264b30c
Compare
mehdirande
changed the title
|
Please create an issue while sending PR. |
tugcekucukoglu
added
the
Resolution: Needs Revision
I created ticket #6371, which is mentioned in the commit message, beforehand. Is this not the correct way to do it? If not, could you please let me know what I did wrong so I can improve for next time? |
tugcekucukoglu
removed
the
Resolution: Needs Revision
tugcekucukoglu
approved these changes
Sep 24, 2024
mehdirande
deleted the
fix-6371-add-slots-data-on-tree-nodetoggleicon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodetoggleicon slot is used to customize expand / collapse and loading icon, but when loading mode is set to icon mode and a node is loading, TreeNode use nodetoggleicon without any props instead of binding node and expanded.
This commit bind node and expanded props to nodetoggleicon slot when loading mode is set to icon and node.loading is true.