New rule: new-color-css-vars
#81
Conversation
🦋 Changeset detectedLatest commit: 821ef4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| output: `<Button sx={{color: 'var(--fgColor-muted, var(--color-fg-muted))'}}>Test</Button>`, | ||
| errors: [ | ||
| { | ||
| message: 'Replace var(--color-fg-muted) with var(--fgColor-muted, var(--color-fg-muted))' |
There was a problem hiding this comment.
Will folks always need to include a fallback value or is this an interim step as we're moving over to the new system?
There was a problem hiding this comment.
Interim step! Once v8 is released and fully rolled out, we will refactor this to not include the fallback. We could also add some logic to remove the old fallbacks, but they won't really hurt anything if they stick around.
There was a problem hiding this comment.
Love it 🤩!
One tiny comment, do we need a docs page for this, or nah? (e.g. no-deprecated-colors)
|
@broccolinisoup @TylerJDev going to merge this and add the docs in a separate PR! |
Adds a new rule to update old color CSS variables with new variables, including a fallback value. This should only run on the
sxprop as we have Stylelint in place to cover thestyledsyntax.