Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add no-drafts-import rule #85

Closed
wants to merge 2 commits into from

Conversation

joshblack
Copy link
Member

The /drafts endpoint in @primer/react has been deprecated in favor of
@primer/react/experimental. This PR adds a new rule, no-drafts-import, that checks for this violation and automatically fixes drafts imports to experimental.

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023

⚠️ No Changeset found

Latest commit: 4da1fe0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lesliecdubs
Copy link
Member

Do we need to configure an auto-reviewers group on this repo? 🤔

@joshblack
Copy link
Member Author

@lesliecdubs great question, this prompted me as well 😂 Updated this over in: #88 (the CODEOWNERS file was just in the wrong place)

@joshblack joshblack requested a review from a team October 13, 2023 17:29
@lesliecdubs
Copy link
Member

Thanks for taking care of that! ✨

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshblack joshblack closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants