Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live-region-element): add tag name to HTMLElementTagNameMap #7

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Feb 13, 2024

Add live-region to the HTMLElementTagName map so that tools like querySelector work as-expected by giving you access to LiveRegionElement instead of a default HTMLElement

Thanks @khiga8 for pointing out that this was not working over in: #4 (review)

Changelog

New

Changed

  • Add live-region to HTMLElementTagName global

Removed

Testing & Reviewing

  • Import the define entrypoint in a test file (or just write this in the define file itself)
  • Write document.querySelector('live-region')
  • Verify that the type points to LiveRegionElement | null and not HTMLElement

@joshblack joshblack merged commit addd53b into main Feb 14, 2024
6 checks passed
@joshblack joshblack deleted the feat/add-live-region-to-tag-name-map branch February 14, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant