fix(octicons-styled): update how package is output to reduce bundle s…

…ize (#1027) * fix(octicons-styled): update how package is output to reduce bundle size * chore: add changeset * chore: update rollup config --------- Co-authored-by: Cameron Dutro <camertron@gmail.com>
primer · Oct 30, 2024 · 12c6fb0 · 12c6fb0
1 parent a46108d
commit 12c6fb0
Show file tree

Hide file tree

Showing 4 changed files with 1,519 additions and 868 deletions.
diff --git a/.changeset/six-buttons-listen.md b/.changeset/six-buttons-listen.md
@@ -0,0 +1,5 @@
+---
+'@primer/octicons': minor
+---
+
+Update the build output to reduce number of generated assets included in the package on npm
diff --git a/lib/octicons_styled/package.json b/lib/octicons_styled/package.json
@@ -19,7 +19,7 @@
     "test": "jest",
     "posttest": "npm run ts-test",
     "lint": "eslint src script",
-    "rollup": "rollup -c"
+    "rollup": "rollup -c --bundleConfigAsCjs"
   },
   "keywords": [
     "GitHub",
@@ -41,13 +41,14 @@
     "styled-components": "4.x || 5.x"
   },
   "devDependencies": {
+    "@babel/core": "7.24.7",
+    "@babel/preset-env": "7.24.7",
+    "@babel/preset-react": "7.24.7",
     "@github/prettier-config": "0.0.4",
+    "@rollup/plugin-babel": "6.0.4",
     "@testing-library/jest-dom": "^5.3.0",
     "@testing-library/react": "^10.0.2",
     "@types/react": "^16.4.6",
-    "babel-preset-env": "^1.7.0",
-    "babel-preset-react": "^6.24.1",
-    "babel-preset-stage-0": "^6.24.1",
     "eslint": "^6.5.1",
     "eslint-plugin-github": "4.1.3",
     "eslint-plugin-jest": "^21.17.0",
@@ -59,9 +60,7 @@
     "next": "^11.1.0",
     "react": "^16.4.0",
     "react-dom": "^16.4.1",
-    "rollup": "^0.62.0",
-    "rollup-plugin-babel": "^3.0.5",
-    "rollup-plugin-commonjs": "^9.1.3",
+    "rollup": "^4.18.0",
     "styled-components": "^5.1.0",
     "typescript": "^3.7.5"
   },

diff --git a/lib/octicons_styled/rollup.config.js b/lib/octicons_styled/rollup.config.js
@@ -1,5 +1,4 @@
-import babel from 'rollup-plugin-babel'
-import commonjs from 'rollup-plugin-commonjs'
+import babel from '@rollup/plugin-babel'
 // eslint-disable-next-line import/no-namespace
 import * as octicons from '../octicons_react/dist/index.esm'
 
@@ -11,36 +10,28 @@ export default [
     plugins: [
       babel({
         babelrc: false,
-        presets: [
-          [require.resolve('babel-preset-env'), {modules: false}],
-          require.resolve('babel-preset-stage-0'),
-          require.resolve('babel-preset-react')
-        ]
-      }),
-      commonjs()
+        presets: [[require.resolve('@babel/preset-env'), {modules: false}], require.resolve('@babel/preset-react')],
+        babelHelpers: 'inline'
+      })
     ],
     output: {
       file: 'dist/index.umd.js',
       format: 'umd',
       name: 'reocticons'
     }
   },
-  ...icons.map(name => ({
-    input: `src/__generated__/icons/${name}.js`,
+  {
+    input: Object.fromEntries(icons.map(name => [`icons/${name}`, `src/__generated__/icons/${name}.js`])),
     plugins: [
       babel({
         babelrc: false,
-        presets: [
-          [require.resolve('babel-preset-env'), {modules: false}],
-          require.resolve('babel-preset-stage-0'),
-          require.resolve('babel-preset-react')
-        ]
-      }),
-      commonjs()
+        presets: [[require.resolve('@babel/preset-env'), {modules: false}], require.resolve('@babel/preset-react')],
+        babelHelpers: 'bundled'
+      })
     ],
     output: {
-      file: `dist/icons/${name}.js`,
+      dir: 'dist',
       format: 'esm'
     }
-  }))
+  }
 ]