-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update thumbsup and thumbsdown icons #1033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e2a199c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
force-pushed
the
colebemis/thumbs
branch
from
October 3, 2024 20:15
47d2de5
to
9a1d308
Compare
github-actions
bot
force-pushed
the
colebemis/thumbs
branch
from
October 3, 2024 20:16
9a1d308
to
95ecfa0
Compare
I'm inclined to 👍 it 😏 . @tallys? |
github-actions
bot
force-pushed
the
colebemis/thumbs
branch
from
October 4, 2024 17:56
98a5cb3
to
1fd7161
Compare
LGTM 👍 👍 |
tallys
approved these changes
Oct 4, 2024
jonrohan
approved these changes
Oct 4, 2024
camertron
approved these changes
Oct 4, 2024
keithamus
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lukasoppermann
approved these changes
Oct 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
thumbsup
andthumbsdown
octicons have always felt a little too cartoony to me and don't match the style of the rest of the icons. I took a stab at redesigning them: