Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate DialogV1 to css modules #5246

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Conversation

keithamus
Copy link
Member

@keithamus keithamus commented Nov 7, 2024

Closes https://github.com/github/primer/issues/4408
Refs https://github.com/github/primer/issues/4309

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: fa7f11c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 7, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5246 November 7, 2024 13:31 Inactive
Copy link
Contributor

github-actions bot commented Nov 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.79 KB (0%)
packages/react/dist/browser.umd.js 98.99 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5246 November 13, 2024 10:07 Inactive
@keithamus keithamus marked this pull request as ready for review November 13, 2024 11:02
@keithamus keithamus requested a review from a team as a code owner November 13, 2024 11:02
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351128

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 13, 2024
@jonrohan jonrohan added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit c4ecb73 Nov 13, 2024
44 checks passed
@jonrohan jonrohan deleted the migrate-dialogv1-to-css-modules branch November 13, 2024 23:57
@primer primer bot mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Dialog integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh javascript Pull requests that update Javascript code staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants