Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Token): Migrate to CSS modules behind feature flag Pt 1 #5251

Merged
merged 10 commits into from
Nov 12, 2024
Merged

feat(Token): Migrate to CSS modules behind feature flag Pt 1 #5251

merged 10 commits into from
Nov 12, 2024

Conversation

randall-krauskopf
Copy link
Collaborator

@randall-krauskopf randall-krauskopf commented Nov 8, 2024 •
edited
Loading

Related To: https://github.com/github/primer/issues/4367

This PR is part 1 of breaking apart a larger PR into grokkable parts.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0628003

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 8, 2024
@randall-krauskopf randall-krauskopf added the skip changeset This change does not need a changelog label Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.75 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 99.18 KB (+0.12% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5251 November 8, 2024 19:05 Inactive
@randall-krauskopf randall-krauskopf changed the title Migrate container and remove button to CSS modules feat(Token): Migrate to CSS modules behind feature flag Pt 1 Nov 8, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5251 November 8, 2024 19:26 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5251 November 8, 2024 19:38 Inactive
@primer-integration
Copy link

primer-integration bot commented Nov 8, 2024 •
edited
Loading

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 8, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5251 November 8, 2024 22:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5251 November 8, 2024 22:35 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350628

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Nov 8, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5251 November 12, 2024 15:30 Inactive
@randall-krauskopf randall-krauskopf marked this pull request as ready for review November 12, 2024 15:40
@randall-krauskopf randall-krauskopf requested a review from a team as a code owner November 12, 2024 15:40
jonrohan
jonrohan reviewed Nov 12, 2024
View reviewed changes
packages/react/src/Token/_RemoveTokenButton.module.css
}

.Bigger {
margin-left: var(--base-size-8);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious could you add this to the .TokenButton[data-size='xlarge'] and .TokenButton[data-size='large'] selectors instead of adding .Bigger?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good callout! Update

@github-actions github-actions bot temporarily deployed to storybook-preview-5251 November 12, 2024 21:06 Inactive
jonrohan
jonrohan reviewed Nov 12, 2024
View reviewed changes
packages/react/src/Token/_RemoveTokenButton.tsx Outdated
data-size={size}
className={clsx(
enabled && classes.TokenButton,
enabled && addLargerMarginClass(size) && classes.Bigger,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
enabled && addLargerMarginClass(size) && classes.Bigger,

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, 🤦 thank you for catching that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@github-actions github-actions bot temporarily deployed to storybook-preview-5251 November 12, 2024 21:15 Inactive
jonrohan
jonrohan approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘🏻

@randall-krauskopf randall-krauskopf added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 536d7ab Nov 12, 2024
43 checks passed
@randall-krauskopf randall-krauskopf deleted the token-css-modules-1 branch November 12, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@broccolinisoup broccolinisoup Awaiting requested review from broccolinisoup broccolinisoup is a code owner automatically assigned from primer/engineer-reviewers

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randall-krauskopf @jonrohan @hussam-i-am