Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectPanel: Introduce loadingType prop to specify initial loading style #5266

Closed
wants to merge 5 commits into from
Closed

SelectPanel: Introduce loadingType prop to specify initial loading style #5266

wants to merge 5 commits into from

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Nov 12, 2024 •
edited
Loading

I discovered a few issues while working on re-introducing the reverted loading states PR and decided to take a different approach by pushing smaller PRs. This is the first PR of a loading state series.

Changelog

New

  • Add loadingType to SelectPanel

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@github-actions github-actions bot added the staff Author is a staff member label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 12, 2024
@broccolinisoup broccolinisoup changed the title SelectPanel: Introduce loadingType prop to specify initial loading style SelectPanel: Introduce loadingType prop to specify initial loading style Nov 12, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5266 November 12, 2024 05:27 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.88 KB (+0.28% 🔺)
packages/react/dist/browser.umd.js 99.27 KB (+0.25% 🔺)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: f287349

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-5266 November 12, 2024 05:54 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5266 November 12, 2024 06:05 Inactive
@broccolinisoup broccolinisoup marked this pull request as ready for review November 12, 2024 06:24
@broccolinisoup broccolinisoup requested a review from a team as a code owner November 12, 2024 06:24
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350777

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 12, 2024
langermank
langermank reviewed Nov 13, 2024
View reviewed changes
packages/react/src/FilteredActionList/Loaders.tsx
function LoadingSkeleton({rows = 10, ...props}: {rows?: number}): JSX.Element {
const id = useId()
return (
<Box p={2} display="flex" flexGrow={1} flexDirection="column">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new internal component, I think it would be best to avoid Box/sx here! Maybe this could be a Stack, or just a div using CSS Modules?

@broccolinisoup
Copy link
Member Author

broccolinisoup commented Nov 15, 2024 •
edited
Loading

This is the first PR of a loading state series.

I am closing this one because I won't be able to work on the rest of the series 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank left review comments

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@broccolinisoup @langermank