Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AvaterToken/IssueLabelToken): Migrate to CSS modules behind feature flag Pt 3 #5268

Closed
wants to merge 15 commits into from

Conversation

randall-krauskopf
Copy link
Collaborator

Related To: https://github.com/github/primer/issues/4367

This PR is part 2 of breaking apart a larger PR into grokkable parts.

Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: ee6571b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 12, 2024
@randall-krauskopf randall-krauskopf added the skip changeset This change does not need a changelog label Nov 12, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5268 November 12, 2024 17:34 Inactive
Copy link
Contributor

github-actions bot commented Nov 12, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.9 KB (+0.16% 🔺)
packages/react/dist/browser.umd.js 99.21 KB (+0.04% 🔺)

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 12, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5268 November 12, 2024 21:16 Inactive
@randall-krauskopf randall-krauskopf changed the base branch from main to token-css-modules-1 November 12, 2024 21:20
@github-actions github-actions bot temporarily deployed to storybook-preview-5268 November 12, 2024 22:00 Inactive
Base automatically changed from token-css-modules-1 to main November 12, 2024 22:16
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350838

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@randall-krauskopf randall-krauskopf changed the title feat(Token): Migrate to CSS modules behind feature flag Pt 2 feat(AvaterToken/IssueLabelToken): Migrate to CSS modules behind feature flag Pt 3 Nov 13, 2024
@randall-krauskopf randall-krauskopf deleted the token-css-modules-2 branch November 18, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants