Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DataTable.docs.json #5269

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Update DataTable.docs.json #5269

merged 2 commits into from
Nov 14, 2024

Conversation

joshblack
Copy link
Member

Update DataTable docs to indicate that the component has been reviewed for accessibility.

This was tackled in our old docs site here: #4743 but was not included in the update.

Changelog

New

Changed

  • Update a11yReviewed to true for DataTable

Removed

@joshblack joshblack requested a review from a team as a code owner November 12, 2024 18:10
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2d6e7be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Nov 12, 2024
@joshblack joshblack added skip changeset This change does not need a changelog and removed staff Author is a staff member labels Nov 12, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5269 November 12, 2024 18:12 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.75 KB (0%)
packages/react/dist/browser.umd.js 99.18 KB (0%)

siddharthkp
siddharthkp approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Feel free to also update the status if you see fit. Approving in advance :shipit:

@joshblack @lesliecdubs
Update packages/react/src/DataTable/DataTable.docs.json
2d6e7be 
Co-authored-by: Leslie Cohn-Wein <lesliecdubs@github.com>
@joshblack joshblack added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 87a7592 Nov 14, 2024
43 checks passed
@joshblack joshblack deleted the joshblack-patch-1 branch November 14, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesliecdubs lesliecdubs lesliecdubs left review comments

@siddharthkp siddharthkp siddharthkp approved these changes

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @siddharthkp @lesliecdubs