Feat/sy without k pin #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinrezC
force-pushed
the
feat/SY-without-k-pin
branch
from
6cc2d7e to
8d00880
Compare
Alexangelj
reviewed
Apr 26, 2024
Comment on lines
+266
to
+268
| IStrategy(_pools[poolId].strategy).postSwapHook( | ||
| msg.sender, poolId, _pools[poolId], state.postSwapHookData | ||
| ); |
There was a problem hiding this comment.
Is it possible to make this a "pre-swap" hook? Could you describe the details of this in the pr more too for reference
There was a problem hiding this comment.
it's post swap because you need to compute the appropriate swap data off chain and once it's validated that becomes the next state, there's nothing you can do preswap here unless you bisect over the nextL which is kind of a nonstarter here imo
src/DFMM.sol
Outdated
| @@ -13,6 +13,7 @@ import { | |||
| downscaleUp | |||
| } from "./lib/ScalingLib.sol"; | |||
| import { LPToken } from "./LPToken.sol"; | |||
| import "forge-std/console2.sol"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temp: working sy branch