Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behavior #27

Merged
merged 13 commits into from
Feb 26, 2024
Merged

Behavior #27

merged 13 commits into from
Feb 26, 2024

Conversation

0xJepsen
Copy link
Contributor

@0xJepsen 0xJepsen commented Feb 24, 2024 •
edited
Loading

This PR does two things:

Closes #26
Closes #25

Most diffs are from the bindings due to contract changes.
wdyt @Autoparallel?

@0xJepsen 0xJepsen added the 💡 feature New features label Feb 24, 2024
@Autoparallel
Copy link
Contributor

Will take a look. Seems tests are broken?

Autoparallel
Autoparallel suggested changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this. I left one long winded comment that I'd like your feedback on.

That and I think a test might be failing?

kit/src/pool/mod.rs Outdated Show resolved Hide resolved
kit/src/behaviors/deployer.rs Outdated Show resolved Hide resolved
Autoparallel
Autoparallel reviewed Feb 25, 2024
View reviewed changes
kit/src/pool/mod.rs Outdated Show resolved Hide resolved
@Autoparallel
fix: deployer_behavior_test() (#28)
a13e646 
The issue was that the decimals type HAS to be a `u8`. It also seems that we need to fix errors bubbling up within the engine. I will make an issue for this.
Autoparallel
Autoparallel approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good

@0xJepsen 0xJepsen merged commit 561212e into main Feb 26, 2024
5 checks passed
@0xJepsen 0xJepsen deleted the behavior branch February 26, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Autoparallel Autoparallel Autoparallel approved these changes

Assignees
No one assigned
Labels
💡 feature New features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: impl pool type for constant sum pool. feat: dfmm kit: deployer behavior.
2 participants
@0xJepsen @Autoparallel