Code

Spearbit post-audit fixes#89

Code

Merged

clemlak merged 183 commits intomainprimitivefinance/DFMM:mainfrom fix/spearbit-auditprimitivefinance/DFMM:fix/spearbit-auditCopy head branch name to clipboardApr 3, 2024

+1,003-614

Commits

Commits on Mar 18, 2024

• test for LP token balance delta on allocate

  kinrezC

  committed
  95b6928

• reproduce audit finding

  kinrezC

  committed
  8cff3fc

• fix liquidity management order of ops

  kinrezC

  committed
  8c675cc

• fix lptoken allocate test assertions

  kinrezC

  committed
  0557365

Commits on Mar 19, 2024

• fix: optimize duplicate tokens loop check

  clemlak

  committed
  27381ed

• fix: DFMM init now returns the totalLiquidity of the pool

  clemlak

  committed
  8040789

• fix: check if token is WETH in _transferFrom

  clemlak

  committed
  d30b822

• test: use WETH address in _transferFrom tests

  clemlak

  committed
  43b769a

• feat: avoid stuck ETH in _transferFrom

  clemlak

  committed
  e1c4eea

• test: add test_DFMM_transferFrom_UsesWETH

  clemlak

  committed
  849cac0

• test: add test_DFMM_transferFrom_UsesWETHAndRefunds

  clemlak

  committed
  6594c38

• feat: add balance zero check before refunding ETH in _transferFrom

  clemlak

  committed
  c62ca0e

• chore: add commit to OZ clone function link

  clemlak

  committed
  fe89db1

• feat: add InvalidReserves error

  clemlak

  committed
  bf1102c

• fix: compare reserves and tokens length in init

  clemlak

  committed
  ed37a9b

• fix: update controller fees minting in swap

  clemlak

  committed
  1fe6809

• test: update test_DFMM_swap_MintsLPTokensToFeeCollector

  clemlak

  committed
  6d3eeb9

• fix: typo in _computeDeallocateDeltasGivenDeltaL NatSpec

  clemlak

  committed
  051f786

• fix: add missing NatSpec to Pool and InitParams structs

  clemlak

  committed
  cfd7ddc

• fix: return controller in ConstantSum getPoolParams

  clemlak

  committed
  163d7d3

• test: add test_ConstantSum_getPoolParams

  clemlak

  committed
  21031b5

• test: update ConstantSum getPoolParams test

  clemlak

  committed
  fa84ff1

• fix: add missing controller param in ConstantSum init

  clemlak

  committed
  88b596b

Commits on Mar 20, 2024

• fix: ConstantSum computeTradingFunction, computeInitialPoolData

  clemlak

  committed
  982765a

• fix: compute deltaLiquidity in validateAllocate in ConstantSum

  clemlak

  committed
  746cbc1

• fix: override validateDeallocate in ConstantSum

  clemlak

  committed
  3f2bd90

• fix: remove incorrect functions in ConstantSumMath

  clemlak

  committed
  f3698b1

• test: update test_ConstantSum_allocate_Works

  clemlak

  committed
  5fcbba3

Commits on Mar 21, 2024

• test: fix ConstantSum init test

  clemlak

  committed
  94a304d

• test: add test_ConstantSum_init_TransfersTokens

  clemlak

  committed
  bd3c680

• test: update test_ConstantSum_init_InitializesPool

  clemlak

  committed
  b30f8b4

Commits on Mar 22, 2024

• test: move ConstantSum init test to dedicated test file

  clemlak

  committed
  f82f84c

• test: add test_ConstantSum_init_StoresPoolParams

  clemlak

  committed
  4f29be9

• test: move ConstantSum no swap fees tests

  clemlak

  committed
  9f6da08

• test: move ConstantSum validateSwap tests to dedicated test file

  clemlak

  committed
  c63ce0c

• test: move ConstantSum swap tests to dedicated test file

  clemlak

  committed
  8fbbc8c

• test: remove old ConstantSumTest

  clemlak

  committed
  a946a7c

• test: add ConstantSum update tests

  clemlak

  committed
  1fe5af1

• test: add test_ConstantSum_getPoolParams_ReturnsPoolParams

  clemlak

  committed
  fb90559

• test: add test_ConstantSum_constructor

  clemlak

  committed
  8d8f8cb

• fix: add InvalidReservesLength error to PairStrategy

  clemlak

  committed
  0903141

• fix: check reserves and tokens array length in ConstantSum

  clemlak

  committed
  af73745

• fix: add pool reserves length check in G3M

  clemlak

  committed
  ca780dc

• fix: add reserves and tokens array length check in LogNormal

  clemlak

  committed
  3bd1bc3

• fix: remove reserveX and reserveY in G3M init struct

  clemlak

  committed
  6154ecd

• fix: use mulDiv to compute G3M deltaLiquidity

  clemlak

  committed
  63ed521

Commits on Mar 25, 2024

• Merge pull request #73 from primitivefinance/fix/lp-token-tracking

  Show description for 8ab9767
  clemlak

  authored
  8ab9767

• Merge branch 'fix/spearbit-audit' into fix/duplicate-tokens-loop

  clemlak

  authored
  fba3699

• Merge pull request #74 from primitivefinance/fix/duplicate-tokens-loop

  Show description for 687a0e3
  clemlak

  authored
  687a0e3

• Merge branch 'fix/spearbit-audit' into fix/returned-emitted-init-liquidity

  clemlak

  authored
  dbdbe65

• Merge pull request #75 from primitivefinance/fix/returned-emitted-init-liquidity

  Show description for 923b3a7
  clemlak

  authored
  923b3a7

• Merge branch 'fix/spearbit-audit' into fix/update-clone-commit-link

  clemlak

  authored
  674f6aa

• Merge pull request #77 from primitivefinance/fix/update-clone-commit-link

  Show description for c9e4d9f
  clemlak

  authored
  c9e4d9f

• Merge branch 'fix/spearbit-audit' into fix/compare-tokens-reserves-length

  clemlak

  authored
  09fc5ec

• Merge branch 'fix/spearbit-audit' into fix/controller-swap-fees

  clemlak

  authored
  436d805

• Merge pull request #79 from primitivefinance/fix/compare-tokens-reserves-length

  Show description for 8d6fffe
  clemlak

  authored
  8d6fffe

• Merge branch 'fix/spearbit-audit' into fix/natspec-typo-compute-deallocate

  clemlak

  authored
  45e6364

• Merge pull request #81 from primitivefinance/fix/natspec-typo-compute-deallocate

  Show description for 55abf6c
  clemlak

  authored
  55abf6c

• Merge branch 'fix/spearbit-audit' into fix/idfmm-natspec

  clemlak

  authored
  f8a507a

• Merge pull request #82 from primitivefinance/fix/idfmm-natspec

  Show description for 1f70427
  clemlak

  authored
  1f70427

• Merge branch 'fix/spearbit-audit' into fix/missing-constant-sum-controller

  clemlak

  authored
  19b012e

• Merge pull request #83 from primitivefinance/fix/missing-constant-sum-controller

  Show description for 7e930dc
  clemlak

  authored
  7e930dc

• Merge branch 'fix/spearbit-audit' into test/constant-sum-tests

  clemlak

  authored
  43da6f2

• test: fix test_ConstantSum_getPoolParams_ReturnsPoolParams

  clemlak

  committed
  22967e4

• Merge pull request #84 from primitivefinance/test/constant-sum-tests

  Show description for c2fdd68
  clemlak

  authored
  c2fdd68

• feat: G3M init pool data now expects array of reserves

  clemlak

  committed
  e3f07d2

• Merge branch 'fix/spearbit-audit' into fix/reserves-length-check

  clemlak

  authored
  03bf4f4

• Merge pull request #85 from primitivefinance/fix/reserves-length-check

  Show description for 7033738
  clemlak

  authored
  7033738

• Merge branch 'fix/spearbit-audit' into fix/g3m-init-struct

  clemlak

  authored
  df79f5a

• Merge pull request #86 from primitivefinance/fix/g3m-init-struct

  Show description for e6496e6
  clemlak

  authored
  e6496e6

• Merge branch 'fix/spearbit-audit' into fix/g3m-compute-delta-liquidity

  clemlak

  authored
  5242573

• Merge pull request #87 from primitivefinance/fix/g3m-compute-delta-liquidity

  Show description for c6fa69b
  clemlak

  authored
  c6fa69b

• Merge branch 'fix/spearbit-audit' into fix/transfer-functions

  clemlak

  authored
  c2f0b5f

Commits on Mar 26, 2024

• feat: update _transferFrom to use arrays of token and address

  clemlak

  committed
  6e84fcf

• test: update _transferFrom tests

  clemlak

  committed
  3e9497c

• fix: remove unchecked scope for toUint

  clemlak

  committed
  de6d27b

• fix: use mulDiv to compute deltas in LogNormalMath

  clemlak

  committed
  8aebaae

• fix: max values for width and mean in LogNormal

  clemlak

  committed
  d18948c

• feat: add mean and witdth max value check in init and update

  clemlak

  committed
  5a37380

• chore: remove mention of tau in LogNormalMath

  clemlak

  committed
  99b0158

• chore: rename old K to mean

  clemlak

  committed
  ad69860

Commits on Mar 27, 2024

• fix: add _computeSwapDeltaLiquidity to PairStrategy

  clemlak

  committed
  3f94e01

• feat: add computeSwapDeltaLiquidity to ConstantSumMath

  clemlak

  committed
  dad2ff5

• feat: add _computeSwapDeltaLiquidity to ConstantSum

  clemlak

  committed
  869f482

• feat: update _computeSwapDeltaLiquidity in PairStrategy

  clemlak

  committed
  bda4065

• chore: add missing NatSpec to _computeSwapDeltaLiquidity

  clemlak

  committed
  e591dea

• feat: add computeSwapDeltaLiquidity to G3MMath

  clemlak

  committed
  28b310c

• feat: add _computeSwapDeltaLiquidity to G3M

  clemlak

  committed
  c9c6f53

• feat: add computeSwapXForYDeltaLiquidity to LogNormalMath

  clemlak

  committed
  b707a67

• feat: add computeSwapYForXDeltaLiquidity in LogNormalMath

  clemlak

  committed
  e05bcb8

• feat: add wip _computeSwapDeltaLiquidity to LogNormal

  clemlak

  committed
  4d4b108

• feat: compute price in LogNormal _computeSwapDeltaLiquidity

  clemlak

  committed
  8c8ce08

• feat: add _computeSwapDeltaLiquidity to NTokenStrategy

  clemlak

  committed
  9562053

• feat: add _computeSwapDeltaLiquidity to NTokenGeometricMean

  clemlak

  committed
  74912bc

• feat: add computeSwapDeltaLiquidity to NTokenG3MMath

  clemlak

  committed
  6a3c914

• feat: remove deltaLiquidity from simulateSwap in LogNormalSolver

  clemlak

  committed
  a6a9ae3

• feat: use same functions to compute swap deltaLiquidity in LogNormal strategy and solver

  clemlak

  committed
  2bec4ff

• feat: fix computeSwapDeltaLiquidity formula in G3MMath

  clemlak

  committed
  166cbaf

• feat: remove deltaLiquidity parameter in simulateSwap from ConstantSumSolver

  clemlak

  committed
  a984a6d

• feat: remove deltaLiquidity parameter in simulateSwap from G3MSolver

  clemlak

  committed
  ba12fb2

• feat: remove deltaLiquidity parameter in simulateSwap from NTokenG3MSolver

  clemlak

  committed
  85a1695

• feat: fix computeSwapDeltaLiquidity in ConstantSumMath

  clemlak

  committed
  fc63b45

Commits on Mar 28, 2024

• Merge branch 'fix/spearbit-audit' into fix/swap-delta-liquidity

  clemlak

  authored
  9bc37f2

• fix: ConstantSum computeSwapDeltaLiquidity

  clemlak

  committed
  fdadbbd

Commits on Mar 29, 2024

• feat: simplify _computeSwapDeltaLiquidity in ConstantSum

  clemlak

  committed
  46c1027

• feat: use mulDiv in computeSwapDeltaLiquidity for ConstantSum

  clemlak

  committed
  7699e52

• feat: use computeSwapDeltaLiquidity in ConstantSumSolver

  clemlak

  committed
  6f12c05

• Merge pull request #76 from primitivefinance/fix/transfer-functions

  Show description for 8fc862a
  clemlak

  authored
  8fc862a

• Merge branch 'fix/spearbit-audit' into fix/controller-swap-fees

  clemlak

  authored
  4052863

• feat: round up pool controller swap fees in DFMM swap

  clemlak

  committed
  f182bac

• feat: check controller fee instead of controller address in DFMM swap

  clemlak

  committed
  1a2a4b4

• Merge pull request #90 from primitivefinance/fix/remove-touint-unchecked

  Show description for 95744d2
  clemlak

  authored
  95744d2

• Merge branch 'fix/spearbit-audit' into fix/log-normal-deltas-rounding

  clemlak

  authored
  e70b54e

• Merge pull request #91 from primitivefinance/fix/log-normal-deltas-rounding

  Show description for 740d28d
  clemlak

  authored
  740d28d

• feat: add min bounds for LogNormal width and mean

  clemlak

  committed
  dce5f77

• Merge branch 'fix/spearbit-audit' into fix/log-normal-bounded-params

  clemlak

  authored
  eccb50c

• fix: add missing closing bracket in LogNormal

  clemlak

  committed
  78ddd8c

• Merge branch 'fix/spearbit-audit' into fix/log-normal-fixed-vars

  clemlak

  authored
  a8f02f3

• Merge pull request #94 from primitivefinance/fix/log-normal-fixed-vars

  Show description for 6311ddc
  clemlak

  authored
  6311ddc

• Merge pull request #95 from primitivefinance/fix/swap-delta-liquidity

  Show description for e7a7867
  clemlak

  authored
  e7a7867

• Merge pull request #97 from primitivefinance/fix/log-normal-trading-function-rounding

  Show description for 1317937
  clemlak

  authored
  1317937

• fix: remove useless return in decodeFeeUpdate in ConstantSumUtils

  clemlak

  committed
  744e716

• fix: remove useless library using in ConstantSumMath

  clemlak

  committed
  da8d520

• fix: remove useless library using in ConstantSumSolver

  clemlak

  committed
  802491b

• fix: remove unused wX parameter in InitState in NTokenG3M

  clemlak

  committed
  5c52003

• fix: move test constants in StrategyLib into test files

  clemlak

  committed
  28315ce

• fix: add deltas array length check in NTokenStrategy

  clemlak

  committed
  a7cf0aa

• fix: use mulDiv for most operations in StrategyLib

  clemlak

  committed
  26f2f8c

• Merge branch 'fix/spearbit-audit' into fix/strategy-lib-muldiv

  clemlak

  authored
  0f5fc6f

• fix: change rounding in G3M trading function

  clemlak

  committed
  80bc05e

• fix: prevent weightX to be 0

  clemlak

  committed
  d5b485d

• fix: add weightX check in G3M update

  clemlak

  committed
  d4b6fd2

• fix: add missing onlyDFMM modifier in NTokenG3M

  clemlak

  committed
  6d2faab

• fix: add remainder to dynamic parameter calculation

  clemlak

  committed
  9605b1f

• fix: remove totalLiquidity from init in ConstantSum

  clemlak

  committed
  3c3b1ae

• Merge branch 'fix/spearbit-audit' into fix/total-liquidity-init

  clemlak

  authored
  7b8df07

• feat: remove L from ConstantSum init pool data

  clemlak

  committed
  6001c4e

• feat: reintroduce EPSILON

  clemlak

  committed
  276ceb3

• feat: use EPSILON to check invariant in ConstantSum ini

  clemlak

  committed
  3333eaf

• feat: use EPSILON to check invariant in G3M init

  clemlak

  committed
  e5db5ac

• feat: use EPSILON to check invariant in LogNormal init

  clemlak

  committed
  5a7b2bc

• feat: use EPSILON to check invariant in NTokenG3M init

  clemlak

  committed
  6ecc8e7

• Merge branch 'fix/spearbit-audit' into fix/controller-swap-fees

  clemlak

  authored
  d9f23f8

• fix: fix SetsValue* tests to account for instantaneous lastComputedValue change

  kinrezC

  committed
  c6209b8

Commits on Apr 1, 2024

• Merge pull request #80 from primitivefinance/fix/controller-swap-fees

  Show description for 86b6b0b
  clemlak

  authored
  86b6b0b

• Merge branch 'fix/spearbit-audit' into fix/minor-issues

  clemlak

  authored
  af6ac26

• Merge pull request #98 from primitivefinance/fix/minor-issues

  Show description for 62eeb36
  clemlak

  authored
  62eeb36

• Merge branch 'fix/spearbit-audit' into fix/g3m-weight-check

  clemlak

  authored
  fa3af60

• Merge pull request #102 from primitivefinance/fix/g3m-weight-check

  Show description for c38bb61
  clemlak

  authored
  c38bb61

• Merge branch 'fix/spearbit-audit' into fix/g3m-trading-function-rounding

  clemlak

  authored
  8cb531c

• Merge pull request #101 from primitivefinance/fix/g3m-trading-function-rounding

  Show description for 274696a
  clemlak

  authored
  274696a

• Merge branch 'fix/spearbit-audit' into fix/missing-modifier-ntokeng3m

  clemlak

  authored
  22313f9

• Merge pull request #103 from primitivefinance/fix/missing-modifier-ntokeng3m

  Show description for 7406c0e
  clemlak

  authored
  7406c0e

• Merge pull request #99 from primitivefinance/fix/ntoken-deltas-array-check

  Show description for 49a20c7
  clemlak

  authored
  49a20c7

• fix: remove computeLGivenY in G3MMath

  clemlak

  committed
  0f0ce53

• Merge branch 'fix/spearbit-audit' into fix/g3m-math

  clemlak

  authored
  2069ef1

• fix: remove computeYGivenL

  clemlak

  committed
  8a6788f

• fix: use mulDivUp in computeLGivenX

  clemlak

  committed
  8a7fa28

• fix: delete unused imports in G3MSolver

  clemlak

  committed
  03ea755

• fix: remove computeXGivenL in G3MMath

  clemlak

  committed
  11861e8

• fix: remove computeX in G3MMath

  clemlak

  committed
  1316bc2

• Merge pull request #111 from primitivefinance/fix/ntoken-g3m-rounding

  Show description for 74719d5
  clemlak

  authored
  74719d5

• Merge branch 'fix/spearbit-audit' into fix/log-normal-bounded-params

  clemlak

  authored
  f332e3d

• Merge pull request #93 from primitivefinance/fix/log-normal-bounded-params

  Show description for a6ed4ed
  clemlak

  authored
  a6ed4ed

• fix: use computeDeltaLiquidity in ConstantSum init

  clemlak

  committed
  cda904a

• Merge branch 'fix/spearbit-audit' into fix/total-liquidity-init

  clemlak

  authored
  cebcdca

• Merge pull request #107 from primitivefinance/fix/total-liquidity-init

  Show description for 8bff684
  clemlak

  authored
  8bff684

• Merge branch 'fix/spearbit-audit' into fix/strategy-lib-muldiv

  clemlak

  authored
  1972c1c

• test: increase default X reserve for LogNormal pools

  clemlak

  committed
  aa9e127

• Merge pull request #100 from primitivefinance/fix/strategy-lib-muldiv

  Show description for 32a5572
  clemlak

  authored
  32a5572

• Fix/unused imports ntokeng3m utils (#109)

  Show description for f597df3
  clemlak

  authored
  f597df3

Commits on Apr 2, 2024

• Merge branch 'fix/spearbit-audit' into fix/g3m-math

  clemlak

  authored
  79c7b22

• Merge branch 'fix/spearbit-audit' into fix/dynamic-library-rounding

  clemlak

  authored
  4fd811a

• Merge pull request #106 from primitivefinance/fix/dynamic-library-rounding

  Show description for bf3c7bf
  clemlak

  authored
  bf3c7bf

• Merge branch 'fix/spearbit-audit' into fix/g3m-math

  clemlak

  authored
  1b9e6ed

• Merge pull request #108 from primitivefinance/fix/g3m-math

  Show description for a2f111e
  clemlak

  authored
  a2f111e

• Fix/ntoken accumulator (#105)

  Show description for b0c9f6f
  

  clemlak

  and

  kinrezC

  authored
  b0c9f6f

• fix: optimize token decimals check in DFMM init (#112)

  clemlak

  authored
  1b7a4dd

• fix: computeNextLiquidity in G3MMath (#114)

  clemlak

  authored
  7868687

• fix: NatSpec in computeLGivenX in LogNormalMath (#113)

  Show description for af5c660
  

  clemlak

  and

  kinrezC

  authored
  af5c660

Commits on Apr 3, 2024

• fix: rounding direction in computeTradingFunction in LogNormalMath

  clemlak

  committed
  89e1a96

• Merge pull request #117 from primitivefinance/fix/log-normal-trading-function

  Show description for 32f9862
  clemlak

  authored
  32f9862

• Merge branch 'main' into fix/spearbit-audit

  clemlak

  authored
  1a3d7b1