Feat/liquidity manager #26
Conversation
kinrezC
commented
Jun 13, 2024
kinrezC
commented
- adds liquidity manager contract for zapping into positions
There was a problem hiding this comment.
The calls seem pretty straightforward:
- pull tokens from user
- approve rmm to spend those pulled tokens
- do rmm swap
- approve swap output tokens to be spent by rmm
- do allocate
Which gives me an idea:
- add multicall and make a public function for each single step (i.e. swap, allocate).
- in frontend, we build a multicall of: deposit tokens (pull from user), swap, allocate
- this would make it so the only difference between allocate from sy or allocate from pt is in the swap call we put in the multicall
Make sure there is no usage of msg.value in multicall stack trace
src/LiquidityManager.sol
Outdated
| } | ||
| } | ||
|
|
||
| function allocateFromSy(IRMM rmm, uint256 amountSy, uint256 minPtOut, uint256 minLiquidityDelta, uint256 initialGuess, uint256 epsilon) external returns (uint256 liquidity) { |
There was a problem hiding this comment.
Address arguments should be addresses, not interfaces. interfaces make it clunky
There was a problem hiding this comment.
Multiple places with this
src/LiquidityManager.sol
Outdated
| uint256 rY = rmm.reserveY(); | ||
|
|
||
| // validate swap approximation | ||
| (uint256 syToSwap,) = computeSyToPtToAddLiquidity(rmm, rX, rY, index, amountSy, block.timestamp, initialGuess, epsilon); |
There was a problem hiding this comment.
Why do we compute syToSwap?
There was a problem hiding this comment.
you have some maxSy and you want to swap some amount of it to approximate the correct proportion of PT and SY for adding liquidity.
src/LiquidityManager.sol
Outdated
|
|
||
| import "./lib/RmmErrors.sol"; | ||
|
|
||
| interface IRMM { |
There was a problem hiding this comment.
Since we already import RMM, we can cast it to RMM
There was a problem hiding this comment.
That was causing weird stack issues with via-ir, no clue why
