Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 01-quickstart.mdx ts-node to tsx #6341

Closed
wants to merge 1 commit into from

Conversation

dannybunschoten
Copy link

The current documentation contains a call to ts-node. However ts-node does not play nicely with ES-modules, and can be a pain to setup. As can be seen in this stackoverflow post. Furthermore, prisma is a platinum sponsor of tsx.

I changed the call from ts-node to tsx to make it easier for beginners to follow the getting started without needing to setup a lot.

This is my first pull request, so please let me know if there are any changes to be made.

Change ts-node to tsx
Copy link
Member

@jharrell jharrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Agreed, we should move to tsx across our docs 😊

@jharrell
Copy link
Member

jharrell commented Nov 5, 2024

Apologies @dannybunschoten ! Our codebase diverged a little bit since your contribution.

This was resolved in #6393

Thank you regardless for the contribution 🙏

@jharrell jharrell closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants