Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Replace custom Callback with Java 8 Completable Future #67

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[enhancement] Replace custom Callback with Java 8 Completable Future #67

wants to merge 3 commits into from

Conversation

damienbeaufils
Copy link
Contributor

Hi Prismic team!

Since Java 8, we can use the new Future reactive API (with CompletableFuture), to execute asynchronous callbacks instead of using a custom Callback interface.
This PR replaces the usage of the custom Callback interface by the standard Java 8 Future API.

@damienbeaufils damienbeaufils changed the title [enhancement] Replace callback with Java 8 Completable Future [enhancement] Replace custom Callback with Java 8 Completable Future Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@damienbeaufils