Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Steve/update pychiquito #107

Closed
wants to merge 21 commits into from
Closed

Steve/update pychiquito #107

wants to merge 21 commits into from

Conversation

qwang98
Copy link
Collaborator

@qwang98 qwang98 commented Aug 23, 2023

Now ready for review. I apologize for a complicated PR as they should be broken up further in retrospect. Changes include:

Tutorials

  • All Fibo tutorials now work (through chapter 5)
  • Added padding related features in Python frontend to support new tutorial chapters
  • Published latest Chiquito Python package 0.2.1 to PyPI
  • Updated README and associated links (including a main README and a Python frontend README)

Changes Related to Fixed Gen

  • To parse Python generated fixed assignments directly to Rust, I moved fixed assignments generation from compiler to dsl/ast
  • As a result, Rust ast no longer stores fixed_gen lambda, but is replaced with fixed_assignments
  • Added associated functions in Python

New (Incomplete) Python Example: Mimc7

  • Mimc7 example works for the mimc7_constants circuit
  • To support this example, Lookup is now enabled in Python frontend and can be parsed to Rust ast
  • The main circuit is still under development and will be pushed in another PR for Python super circuit

@qwang98 qwang98 requested a review from leolara August 28, 2023 22:40
This was linked to issues Aug 28, 2023
@qwang98 qwang98 mentioned this pull request Aug 28, 2023
@qwang98 qwang98 marked this pull request as ready for review August 28, 2023 23:24
@leolara
Copy link
Collaborator

leolara commented Aug 28, 2023

I am sorry Steve, this needs to be broken down. Please, think about the order in which these things depend on each other and send the PRs in that order.

Also, we need to decide about the versioning. I don't think next version should be 0.2.1. I think we should keep the vYYYY_MM_DD if that is possible in pypi.

Then when it is more stable we can for another versioning

@qwang98
Copy link
Collaborator Author

qwang98 commented Aug 29, 2023

I am sorry Steve, this needs to be broken down. Please, think about the order in which these things depend on each other and send the PRs in that order.

Also, we need to decide about the versioning. I don't think next version should be 0.2.1. I think we should keep the vYYYY_MM_DD if that is possible in pypi.

Then when it is more stable we can for another versioning

I tried a few times and versioning in the format of vYYYY_MM_DD or YYYY_MM_DD won't work. I run into build errors from the CI.

error: failed to parse manifest at `/home/runner/work/chiquito/chiquito/Cargo.toml`

Caused by:
  unexpected character '_' after major version number for key `package.version`
Error: Process completed with exit code 101.

An alternative solution is to use the regular versioning numbers, e.g. 0.2.1, for now. (It's not like we can use any alternative versioning format tbh.) When we are more stable, we can delete the package and re-upload it. Thoughts?

@leolara
Copy link
Collaborator

leolara commented Aug 29, 2023

I think v0.YYYY_MM_DD would be better so in the future we can switch.

Perhaps we can do v0.1.YYYYMMDD for now and use the same for the branches. Are you aware of the Tran PR on this?

@qwang98
Copy link
Collaborator Author

qwang98 commented Aug 29, 2023

I think v0.YYYY_MM_DD would be better so in the future we can switch.

Perhaps we can do v0.1.YYYYMMDD for now and use the same for the branches. Are you aware of the Tran PR on this?

I think we can do 0.1.20230828 for now. Unfortunately I already published 0.2.0 and 0.2.1 but let's not worry about those ;)

@leolara
Copy link
Collaborator

leolara commented Aug 29, 2023

We can delete the published versions I think. Also I think we need to add two additional 00 at the end in case there is more than one version in the same day

@qwang98
Copy link
Collaborator Author

qwang98 commented Aug 29, 2023

We can delete the published versions I think. Also I think we need to add two additional 00 at the end in case there is more than one version in the same day

kk this works.

@qwang98
Copy link
Collaborator Author

qwang98 commented Aug 29, 2023

Tutorial PR ready for review at #115

I will break up the rest later.

@qwang98
Copy link
Collaborator Author

qwang98 commented Aug 29, 2023

Closed as it's broken into PR #115 #116 #117

@qwang98 qwang98 closed this Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notebooks tutorial broken Refactor fixed assignments Update README.md
2 participants