This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Add test to lookup builder #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolara
reviewed
Oct 14, 2023
| let enable = in_place_lookup_builder.lookup.enable; | ||
| assert_eq!(annotation, ""); | ||
| assert_eq!(format!("{:?}",exprs), "[]"); | ||
| assert_eq!(format!("{:?}", enable), "None"); |
There was a problem hiding this comment.
@motemotech cannot you compare to value None without converting to string?
leolara
reviewed
Oct 14, 2023
| let exprs = in_place_lookup_builder.lookup.exprs; | ||
| let enable = in_place_lookup_builder.lookup.enable; | ||
| assert_eq!(annotation, ""); | ||
| assert_eq!(format!("{:?}",exprs), "[]"); |
There was a problem hiding this comment.
@motemotech I think you can check exprs.len() eq 0, without converting to string
leolara
approved these changes
Oct 14, 2023
|
@motemotech it is approved, a few simple comparisions do not need converting to string. |
|
@motemotech Feel free to merge it after fixing the CI checks. |
|
@motemotech are you going to fix the problems? |
leolara
force-pushed
the
main
branch
4 times, most recently
from
03ddbb5 to
8397503
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.