This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
WIP: Issue 75 add unit tests to DSL #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good, but missing more things to test |
…:nullbitx8/chiquito into issue-75-add-unit-tests-to-dsl
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 49.67% 54.08% +4.40%
==========================================
Files 21 21
Lines 5751 5941 +190
==========================================
+ Hits 2857 3213 +356
+ Misses 2894 2728 -166 ☔ View full report in Codecov by Sentry. |
|
@nullbitx8 fix the fmt please |
Will do. I plan on adding more tests, would you prefer I keep working on this PR or on another? |
|
It is good to keep working on this. Thanks |
…:nullbitx8/chiquito into issue-75-add-unit-tests-to-dsl
leolara
approved these changes
Nov 18, 2023
leolara
force-pushed
the
main
branch
4 times, most recently
from
03ddbb5 to
8397503
Compare
Merged
via the queue into
privacy-scaling-explorations:main
with commit Nov 21, 2023
69745a5
4 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress for #75
I am planning to add code coverage as well as more tests.