This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Fix definition references for declarations #262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small issue with how we were recording the definition references for declarations. We were counting the whole entry of the AST as its definition. For example, here:
the definition start was the start of the word "state" and the end was the closing curly bracket. This PR fixes the definition references to be the span of the identifier (in this example, just the
new_state
).Benefits: