This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Padding for chiquito 2024 #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rutefig
suggested changes
Jul 6, 2024
There was a problem hiding this comment.
Really nice refactor, was great to read the refactored code and see how clean it went. It is also good to learn from reading this PR :)
Checked some minor stuff that can be refactored for better organisation and clarity, and other that that just some prints and comments that I think can be removed.
|
@rutefig check again |
alxkzmn
reviewed
Jul 10, 2024
alxkzmn
reviewed
Jul 10, 2024
alxkzmn
reviewed
Jul 10, 2024
|
@alxkzmn check now |
|
@leolara Thanks for the clarifications, looks good to me! |
alxkzmn
reviewed
Jul 11, 2024
alxkzmn
approved these changes
Jul 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.