Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about page new design #146

Merged
merged 1 commit into from
Feb 28, 2024
Merged

about page new design #146

merged 1 commit into from
Feb 28, 2024

Conversation

kalidiagne
Copy link
Collaborator

Refactor about page to match new design

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-v2 ✅ Ready (Inspect) Visit Preview Feb 27, 2024 3:49am
website-v2-production ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 3:49am

Copy link
Contributor

@ChialiT ChialiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and there was few PR for fixing typo, make sure we include them.

@ChialiT ChialiT requested a review from heeckhau February 28, 2024 14:37
Copy link
Collaborator

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better indeed. Good work.

The only remark I have is that I prefer the original multi-paragraph approach for the "Our Principles" section.

app/i18n/locales/en/about-page.json Show resolved Hide resolved
@kalidiagne kalidiagne merged commit 7f17fcf into main Feb 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants