Add comment regarding RwTableTag (#1735)

Adds a comment so that it makes it clear what is RwTableTag when going through the code.
privacy-scaling-explorations · Jan 17, 2024 · 05b2b17 · 05b2b17
1 parent d5fe917
commit 05b2b17
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/bus-mapping/src/operation.rs b/bus-mapping/src/operation.rs
@@ -91,6 +91,7 @@ impl RWCounter {
 }
 
 /// Enum used to differenciate between EVM Stack, Memory and Storage operations.
+/// This is also used as the RwTableTag for the RwTable.
 #[derive(Debug, Clone, PartialEq, Eq, Copy, EnumIter, Hash)]
 pub enum Target {
     /// Start is a padding operation.

diff --git a/zkevm-circuits/src/evm_circuit/table.rs b/zkevm-circuits/src/evm_circuit/table.rs
@@ -280,7 +280,7 @@ pub(crate) enum Lookup<F> {
         /// A boolean value to specify if the access record is a read or write.
         is_write: Expression<F>,
         /// Tag to specify which read-write data to access, see RwTableTag for
-        /// all tags.
+        /// all tags. RwTableTag is bus_mapping::operation::Target (PR#1406)
         tag: Expression<F>,
         /// Values corresponding to the tag.
         values: RwValues<F>,

diff --git a/zkevm-circuits/src/table/rw_table.rs b/zkevm-circuits/src/table/rw_table.rs
@@ -8,7 +8,7 @@ pub struct RwTable {
     pub rw_counter: Column<Advice>,
     /// Is Write
     pub is_write: Column<Advice>,
-    /// Tag
+    /// Tag (bus_mapping::operation::Target)
     pub tag: Column<Advice>,
     /// Key1 (Id)
     pub id: Column<Advice>,