nit pics

Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
privacy-scaling-explorations · Apr 22, 2024 · 3dd7bd4 · 3dd7bd4
1 parent 1b1a8a8
commit 3dd7bd4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/bus-mapping/src/evm/opcodes/tload.rs b/bus-mapping/src/evm/opcodes/tload.rs
@@ -45,8 +45,7 @@ impl Opcode for Tload {
         state.stack_read(&mut exec_step, stack_position, key)?;
 
         // Transient Storage read
-        let (_, value) = state.sdb.get_transient_storage(&contract_addr, &key);
-        let value = *value;
+        let (_, &value) = state.sdb.get_transient_storage(&contract_addr, &key);
 
         state.push_op(
             &mut exec_step,

diff --git a/geth-utils/gethutil/trace.go b/geth-utils/gethutil/trace.go
@@ -300,13 +300,6 @@ func ToTxData(message core.Message, ChainID *big.Int) types.TxData {
 			BlobHashes: message.BlobHashes,
 			BlobFeeCap: uint256.MustFromBig((*big.Int)(message.BlobGasFeeCap)),
 		}
-		// if message.Blobs != nil {
-		// 	data.(*types.BlobTx).Sidecar = &types.BlobTxSidecar{
-		// 		Blobs:       message.Blobs,
-		// 		Commitments: message.Commitments,
-		// 		Proofs:      message.Proofs,
-		// 	}
-		// }
 
 	case message.GasFeeCap != nil:
 		al := types.AccessList{}

diff --git a/zkevm-circuits/src/evm_circuit/execution/sstore.rs b/zkevm-circuits/src/evm_circuit/execution/sstore.rs
@@ -56,7 +56,7 @@ impl<F: Field> ExecutionGadget<F> for SstoreGadget<F> {
 
         let tx_id = cb.call_context(None, CallContextFieldTag::TxId);
 
-        // constraint not in static call
+        // Constrain we're not in a STATICCALL context.
         let is_static = cb.call_context(None, CallContextFieldTag::IsStatic);
         cb.require_zero("is_static is false", is_static.expr());