Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Commit

Permalink
chores: fix typo
Browse files Browse the repository at this point in the history
  • Loading branch information
hero78119 committed Mar 21, 2024
1 parent 847292b commit d43f014
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion gadgets/src/permutation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
//! power of gamma are defined in columns to trade more columns with less degrees
use std::iter;
#[rustfmt::skip]
// | q_row_non_first | q_row_enable | q_row_last | alpha | gamma | gamma power 2 | ... | row fingerprint | accmulated fingerprint |
// | q_row_non_first | q_row_enable | q_row_last | alpha | gamma | gamma power 2 | ... | row fingerprint | accumulated fingerprint |
// |-----------------|--------------|------------|-----------|-----------|-----------------| | --------------- | ---------------------- |
// | 0 |1 |0 |alpha | gamma | gamma **2 | ... | F | F |
// | 1 |1 |0 |alpha | gamma | gamma **2 | ... | F | F |
Expand Down
2 changes: 1 addition & 1 deletion zkevm-circuits/src/evm_circuit/execution.rs
Original file line number Diff line number Diff line change
Expand Up @@ -874,7 +874,7 @@ impl<F: Field> ExecutionConfig<F> {

// constraint global rw counter value at first/last step via chunk_ctx_table lookup
// we can't do it inside constraint_builder(cb)
// because lookup expression in constraint builder DONOT support apply conditional
// because lookup expression in constraint builder DO NOT support apply conditional
// `step_first/step_last` selector at lookup cell.
if execute_state_first_step_whitelist.contains(&execution_state) {
meta.lookup_any("first must lookup initial rw_counter", |meta| {
Expand Down
2 changes: 1 addition & 1 deletion zkevm-circuits/src/state_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ impl<F: Field> SubCircuit<F> for StateCircuit<F> {
) = layouter.assign_region(
|| "state circuit",
|mut region| {
// TODO optimimise RwMap::table_assignments_prepad calls from 3 times -> 1
// TODO optimise RwMap::table_assignments_prepad calls from 3 times -> 1
let padded_rows = config.rw_table.load_with_region(
&mut region,
&self.rows,
Expand Down
2 changes: 1 addition & 1 deletion zkevm-circuits/src/table/chunk_ctx_table.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ impl ChunkCtxTable {
pub fn construct<F: Field>(meta: &mut ConstraintSystem<F>) -> Self {
let (q_enable, tag, value) = (meta.selector(), meta.fixed_column(), meta.advice_column());

// constraint NextChunkIndex = CurrentChunkIndex + 1
// constrain NextChunkIndex = CurrentChunkIndex + 1
meta.create_gate("NextChunkIndex = CurrentChunkIndex + 1", |meta| {
let q_enable = meta.query_selector(q_enable);
let value_cur = meta.query_advice(value, Rotation::cur());
Expand Down
5 changes: 2 additions & 3 deletions zkevm-circuits/src/witness/chunk.rs
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,8 @@ pub fn chunk_convert<F: Field>(
if start == 0 {
(None, RwMap::from(skipped.take(size).collect::<Vec<_>>()))
} else {
// here have `chunk.ctx.idx - 1` because each chunk first row are propagated from
// prev chunk. giving idx>0 th chunk, there will be (idx-1) placeholders cant' count
// in real order
// here we got `chunk.ctx.idx - 1` because each chunk first row are propagated from
// prev chunk. giving idx>0 th chunk, there will be (idx-1) placeholders.
let mut skipped = skipped.skip(start - 1 - (chunk.ctx.idx - 1));
let prev_chunk_last_by_address_rw = skipped.next();
(
Expand Down

0 comments on commit d43f014

Please sign in to comment.