This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when is_mod_extension
github-actions
bot
added
crate-zkevm-circuits
Issues related to the zkevm-circuits workspace member
T-bench
Type: benchmark improvements
crate-circuit-benchmarks
Issues related to the circuit-benchmarks workspace member
labels
Aug 14, 2023
miha-stopar
changed the title
is_mod_extension added to branch/leaf; some leaf constraints omitted …
ModExtensionGadget
Sep 1, 2023
Closed in favour of #1685. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
crate-circuit-benchmarks
Issues related to the circuit-benchmarks workspace member
crate-zkevm-circuits
Issues related to the zkevm-circuits workspace member
T-bench
Type: benchmark improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for modified extension nodes.
This happens when an extension node is replaced by another (shorter or longer) extension node. For example, we have an extension node at
n1 n2 n3 n4 n5 n6
with branch with two leaves at positionsn
andm
. If we add a leaf atn1 n2 n3 n4 n7
wheren5 != n7
, a new extension node is inserted atn1 n2 n3 n4
with a new branch with an extension node at positionn5
(with only one nibblen6
) and a leaf at positionn7
. In this case, the S proof contains the extension node atn1 n2 n3 n4 n5 n6
and no underlying branch and leaf (the modification happens atn1 n2 n3 n4 n7
and only an extension node is find there), thus we need to add a placeholder branch and a placeholder leaf.Type of change