Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

ModExtensionGadget #1563

Closed
wants to merge 31 commits into from
Closed

ModExtensionGadget #1563

wants to merge 31 commits into from

Conversation

miha-stopar
Copy link
Collaborator

Description

Support for modified extension nodes.

This happens when an extension node is replaced by another (shorter or longer) extension node. For example, we have an extension node at n1 n2 n3 n4 n5 n6 with branch with two leaves at positions n and m. If we add a leaf at n1 n2 n3 n4 n7 where n5 != n7, a new extension node is inserted at n1 n2 n3 n4 with a new branch with an extension node at position n5 (with only one nibble n6) and a leaf at position n7. In this case, the S proof contains the extension node at n1 n2 n3 n4 n5 n6 and no underlying branch and leaf (the modification happens at n1 n2 n3 n4 n7 and only an extension node is find there), thus we need to add a placeholder branch and a placeholder leaf.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@github-actions github-actions bot added crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member labels Aug 14, 2023
@miha-stopar miha-stopar mentioned this pull request Aug 14, 2023
4 tasks
@miha-stopar miha-stopar changed the title is_mod_extension added to branch/leaf; some leaf constraints omitted … ModExtensionGadget Sep 1, 2023
@miha-stopar miha-stopar mentioned this pull request Sep 11, 2023
4 tasks
@ed255 ed255 linked an issue Sep 21, 2023 that may be closed by this pull request
@miha-stopar
Copy link
Collaborator Author

Closed in favour of #1685.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPT: Support for modified extension nodes.
1 participant