-
Notifications
You must be signed in to change notification settings - Fork 858
Conversation
a8f7830
to
2aeb742
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This CI does nothing in this repo yet. Will fix them in the following PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM following the rationale described in the PR (which is just moving the external repo to zkevm-circuits, and iterate the implementation in future PRs)
From the quick look here are some comments that could be addressed in future PRs:
- Make it explicit which files come from go-ethereum and which ones are new. Also mention the go-ethereum version used (or the commit hash). For the files that come from go-ethereum, make it explicit which functions/types have been changed or introduced.
- I noticed lines of commented code. I think some of that comes from go-ethereum file; maybe the desire was to disable some functionality. Comments on why that is disabled would be helpful
- In some of the test files I noticed many functions that look very similar but have different input-ouputs. I think there's a big opportunity of reusing code there.
- Are all the files and functions strictly needed? For types and public functions that are not modified, could we instead import them from go-ethereum instead of copying them?
Regarding possible formatting of the code in future PRs, I think it would be ideal if the files imported from go-ethereum are not formatted differently than they appear in go-ethereum, so we can quickly diff both sides to see the differences without noise.
LGTM for dropping the go code into the repo. Note that I will be working on the rust wrapper because I need it for the light client. |
Description
MPT witness generator was developed here. We now port them to here.
Issue Link
#1566
Type of change
New feature (non-breaking change which adds functionality)
Contents
Rationale
.git
folder. This way, we don't hide any modifications in the big diffs.How Has This Been Tested?
No test