Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

bus-mapping: improve self-destruct #1613

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

lispc
Copy link
Collaborator

@lispc lispc commented Sep 19, 2023

Description

resolves #1612

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

tested with thousands of mainnet blocks (in scroll fork mainnet.rs tool)

@github-actions github-actions bot added the crate-bus-mapping Issues related to the bus-mapping workspace member label Sep 19, 2023
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for upstreaming this.

@lispc
Copy link
Collaborator Author

lispc commented Sep 19, 2023

not big change, will merge

@lispc lispc enabled auto-merge September 19, 2023 07:33
@ChihChengLiang ChihChengLiang merged commit 86c35ba into main Sep 19, 2023
13 checks passed
@ChihChengLiang ChihChengLiang deleted the fix/self-destruct-bus-mapping branch September 19, 2023 07:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opcode(self-destruct): improve bus-mapping
2 participants