This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Add keccak circuit to LightClientCircuit #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate-zkevm-circuits
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add KeccakCircuit to the LightClientCircuit
Issue Link
Resolve #1619
Type of change
Contents
The current LightClient was verifying MPT proofs but the keccak hashes were not being verified, as only the Keccak Table was present but not the KeccackCircuit. This PR introduces the KeccakCircuit so that the contents of the KeccakTable are verified.
Note that some changes in this PR come from formatting the Rust code, so they are just code format adjustments.
How Has This Been Tested?
This hasn't been tested yet. Two results are missing: