Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

feat: support prevrandao #1648

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat: support prevrandao #1648

merged 1 commit into from
Oct 11, 2023

Conversation

dyxushuai
Copy link
Contributor

Close #1376

@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-mock Issues related to the mock workspace member crate-eth-types Issues related to the eth-types workspace member crate-geth-utils Issues related to the geth-utils workspace member labels Oct 7, 2023
@dyxushuai dyxushuai mentioned this pull request Oct 7, 2023
Closed
ChihChengLiang
ChihChengLiang approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bus-mapping/src/circuit_input_builder/block.rs
Comment on lines -63 to +69
/// time
/// gas limit
pub gas_limit: u64,
/// number
pub number: Word,
/// difficulty
/// time
pub timestamp: Word,
/// gas limit
/// difficulty
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the document fix. 👍🏽

KimiWu123
KimiWu123 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@KimiWu123 KimiWu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChihChengLiang ChihChengLiang added this pull request to the merge queue Oct 11, 2023
Merged via the queue into privacy-scaling-explorations:main with commit ba4da23 Oct 11, 2023
11 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KimiWu123 KimiWu123 KimiWu123 approved these changes

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

Assignees
No one assigned
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member crate-eth-types Issues related to the eth-types workspace member crate-geth-utils Issues related to the geth-utils workspace member crate-mock Issues related to the mock workspace member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support prevrandao opcode
3 participants
@dyxushuai @ChihChengLiang @KimiWu123