Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Grammatical corrections in eth-types #1708

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

fakefraud
Copy link
Contributor

@fakefraud fakefraud commented Dec 13, 2023

Hello I am learning web3 programming, I went through some of the code because I was told zk is fascinating (and it is). I found some little errors in comments, nothing important. I hope you don't mind opening a PR for such a little thing, I read the contributing file and didn't find it being forbidden, but even if it is little I hope i'll help you even just a bit in your research. Thank you for making that repo public. Have a nice day.

@github-actions github-actions bot added the crate-eth-types Issues related to the eth-types workspace member label Dec 13, 2023
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vehorny Please confirm you're not a bot by solving this puzzle: https://WriteYourUsernameInUpperCase.com

@fakefraud
Copy link
Contributor Author

@vehorny Please confirm you're not a bot by solving this puzzle: https://WriteYourUsernameInUpperCase.com

VEHORNY
If it's not right, I'm missing something, because the website isn't working for me

Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChihChengLiang ChihChengLiang added this pull request to the merge queue Dec 18, 2023
Merged via the queue into privacy-scaling-explorations:main with commit 734e430 Dec 18, 2023
11 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crate-eth-types Issues related to the eth-types workspace member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants