This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
chore: set resolver v2 at the workspace level #1731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cargo defaults to
resolver = "2"
in edition 2021 only for singular crates. Workspace tho defaults to the oldresolver = "1"
and will override this setting for all crates in the workspace. The guideline is to manually set theresolver = "2"
on workspace level.This was documented recently and since a few releases produces a warning on building. You don't see it due to the
rust-toolchain
setting.Type of change
Contents
resolver = "2"
on workspace levelresolver = "2"
from light-client-poc/Cargo.toml because it was ignored anywayThis also fixes this warning: