Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Dependency cleaning round #1741

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Dependency cleaning round #1741

merged 2 commits into from
Jan 23, 2024

Conversation

ChihChengLiang
Copy link
Collaborator

Description

We removed the warning message shown during the project build.

warning: the following packages contain code that will be rejected by a future version of Rust: traitobject v0.1.0
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2`

The message is caused by an unused dependency introduced during #1615

Issue Link

None

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Contents

  • Removed some unused dependencies
  • Removed some unused imports

How Has This Been Tested?

Local build on all targets

@github-actions github-actions bot added crate-zkevm-circuits Issues related to the zkevm-circuits workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-geth-utils Issues related to the geth-utils workspace member crate-gadgets Issues related to the gadgets workspace member labels Jan 22, 2024
han0110
han0110 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also rebased & double-checked the lock file locally and it's almost up to date (only chrono is not the lastest version).

@miha-stopar miha-stopar self-requested a review January 23, 2024 12:20
miha-stopar
miha-stopar approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@miha-stopar miha-stopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChihChengLiang ChihChengLiang added this pull request to the merge queue Jan 23, 2024
@ChihChengLiang ChihChengLiang removed this pull request from the merge queue due to a manual request Jan 23, 2024
@adria0 adria0 added this pull request to the merge queue Jan 23, 2024
@adria0 adria0 removed this pull request from the merge queue due to a manual request Jan 23, 2024
@ChihChengLiang ChihChengLiang added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit d972588 Jan 23, 2024
15 checks passed
@ChihChengLiang ChihChengLiang deleted the dep-cleaning branch January 23, 2024 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@han0110 han0110 han0110 approved these changes

@miha-stopar miha-stopar miha-stopar approved these changes

Assignees
No one assigned
Labels
crate-gadgets Issues related to the gadgets workspace member crate-geth-utils Issues related to the geth-utils workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChihChengLiang @miha-stopar @han0110