Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

upgrade halo2 ecosystem dependencies #1749

Merged
merged 1 commit into from
Feb 1, 2024
Merged

upgrade halo2 ecosystem dependencies #1749

merged 1 commit into from
Feb 1, 2024

Conversation

hero78119
Copy link
Member

@hero78119 hero78119 commented Feb 1, 2024 •
edited
Loading

Description

  • halo2 (v2023_04_20 -> v0.3.0)
  • halo2wrong (v2023_04_20 -> v2024_01_31)
  • snark-verifier (v2023_04_20 -> v2024_01_31)
  • remove halo2curves patching and fetch from crate-io, which got latest release 0.6.0

Issue Link

#1691

Type of change

  • New feature (non-breaking change which adds functionality)

@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-eth-types Issues related to the eth-types workspace member crate-gadgets Issues related to the gadgets workspace member labels Feb 1, 2024
@hero78119 hero78119 changed the title upgrade halo2/halo2curves dependency upgrade dependencies Feb 1, 2024
@hero78119 hero78119 changed the title upgrade dependencies upgrade halo2 ecosystem dependencies Feb 1, 2024
ChihChengLiang
ChihChengLiang approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 nitpick.

zkevm-circuits/src/mpt_circuit.rs
Comment on lines +810 to 811
// assert_eq!(prover.verify(), Ok(()));
// prover.assert_satisfied();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two are comments. We can remove them

Suggested change
// assert_eq!(prover.verify(), Ok(()));
// prover.assert_satisfied();

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its ok to leave them to be clean up later, since mpt feature still under development.

han0110
han0110 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hero78119 hero78119 added this pull request to the merge queue Feb 1, 2024
Merged via the queue into privacy-scaling-explorations:main with commit 90eebff Feb 1, 2024
15 checks passed
@hero78119 hero78119 deleted the upgrade_dep branch February 1, 2024 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@han0110 han0110 han0110 approved these changes

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

Assignees
No one assigned
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-eth-types Issues related to the eth-types workspace member crate-gadgets Issues related to the gadgets workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hero78119 @ChihChengLiang @han0110