This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
unify word interface for zero/one #1754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-zkevm-circuits
hero78119
force-pushed
the
poc_unify_mptcircuit_word
branch
from
6934fe3 to
4f168b2
Compare
hero78119
force-pushed
the
poc_unify_mptcircuit_word
branch
from
4f168b2 to
0b4ac52
Compare
hero78119
force-pushed
the
poc_unify_mptcircuit_word
branch
from
0b4ac52 to
8a21678
Compare
|
Included in #1758 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
to address discussion in PR #1748
Rationale
OpsIdentityand implement it forField,Expression<F>type, therefore we can move zero(), one() method to basewordtype