Testool fix from Scroll #1816
Testool fix from Scroll #1816
Conversation
| @@ -10,6 +10,13 @@ path="tests/src/GeneralStateTestsFiller/**/*" | |||
| max_gas = 0 | |||
| max_steps = 100000 | |||
|
|
|||
| [[suite]] | |||
There was a problem hiding this comment.
Not sure, do we need to add this @ChihChengLiang ?
There was a problem hiding this comment.
We should add this one since our TLOAD TSTORE is implemented.
|
Another question - do we need to do changes in codehash.txt, as it's done here ? @ChihChengLiang |
There was a problem hiding this comment.
do we need to do changes in codehash.txt
We should add changes to codehash.txt. The content is the cached mapping of code hash to the corresponding bytecode. When we run the EIP1153 test, cached entries should be automatically generated. We check in those entries to reduce the testing overhead.
| @@ -10,6 +10,13 @@ path="tests/src/GeneralStateTestsFiller/**/*" | |||
| max_gas = 0 | |||
| max_steps = 100000 | |||
|
|
|||
| [[suite]] | |||
There was a problem hiding this comment.
We should add this one since our TLOAD TSTORE is implemented.
@ChihChengLiang - We have an old version of ethereum/tests submodule, that doesn't contain Cancun tests.
|
|
@curryrasul Can you push the update for the ethereum/test submodule? |
|
@ChihChengLiang I updated the tests submodule To reproduce the error:
It returns: |
Description
This PR adds fixes from Scroll/testool - scroll-tech#1235.
Initially I wanted to do that by
cherry-pick, but it added much more here - so I did it manually.