Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec for cookie partition keys and partitioned storage keys #78

Merged
merged 10 commits into from
Jul 22, 2024

Conversation

svendlarsen
Copy link
Contributor

@svendlarsen svendlarsen commented Jul 8, 2024

Namely, when deleting cookies for a host:

  • Preserve cookies for that host partitioned under other sites, but
  • delete cookies partitioned under sites with that host.

And change non-cookie storage deletion:

  • from looking at the storage key's origin
  • to looking at the storage key's top-level site.

Fixes #75.


Preview | Diff

Copy link
Collaborator

@jyasskin jyasskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good enough from a spec point of view, but I'd also like @bvandersloot-mozilla to confirm that this fixes his bug report.

index.bs Outdated Show resolved Hide resolved
Copy link

@bvandersloot-mozilla bvandersloot-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This resolves the issue.

index.bs Outdated Show resolved Hide resolved
Copy link
Member

@johannhof johannhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I think overall, the way we'd rather do this in the future is to expose some interface for this in the cookies RFC (which defines the cookie store) as web platform specs don't necessarily have direct introspection into the cookie store. @annevk any thoughts?

With that said, I acknowledge that we're not fully there yet and so I'm okay with this as I think it's sketching out the correct steps. We can add this to the list for cookie layering work...

index.bs Outdated Show resolved Hide resolved
@wanderview
Copy link
Collaborator

I think this PR also needs to specify the deletion of partitioned non-cookie storage. If non-cookie storage partitioning is not specified adequately yet we should at least add a note indicating that is the intent.

@svendlarsen svendlarsen changed the title Specify handling of partitioned cookies in deletion Update spec for cookie partition keys and partitioned storage keys Jul 22, 2024
@svendlarsen
Copy link
Contributor Author

It seems like we've reached agreement on this change, at least given the current state of related spec/standard changes. I'm going to merge; please note any new concerns by filing an issue. Thanks all for your input!

@wanderview
Copy link
Collaborator

I think you need to drop the phantom link to the top-level site for the partition key. Getting this failure on trying to submit:

image

@wanderview wanderview merged commit 1fa286a into privacycg:main Jul 22, 2024
1 check passed
github-actions bot added a commit that referenced this pull request Jul 22, 2024
SHA: 1fa286a
Reason: push, by wanderview

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete CHIPS cookies
6 participants