Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine contextualbar #1329

Merged
merged 6 commits into from
Jul 15, 2024
Merged

refine contextualbar #1329

merged 6 commits into from
Jul 15, 2024

Conversation

avriq
Copy link
Contributor

@avriq avriq commented Jul 12, 2024

  • remove body transform to avoid broken modal view
  • contextualbar is relative to the parent by default
  • when need fixed contextualbar, it can be setupable using fixed prop

@avriq avriq added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jul 12, 2024
@avriq avriq requested a review from adenvt July 12, 2024 07:23
@avriq avriq self-assigned this Jul 12, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 7:36am

@avriq avriq linked an issue Jul 12, 2024 that may be closed by this pull request
Contextualbar: refine contextualbar #1328
Closed
@adenvt adenvt added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 2b35d17 Jul 15, 2024
11 checks passed
@adenvt adenvt deleted the fix/contextual-bar branch July 15, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adenvt adenvt adenvt approved these changes

Assignees

@avriq avriq

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
Persona Design System
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contextualbar: refine contextualbar
2 participants
@avriq @adenvt