Reworked function discovery #2 #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps detect external method definitions. We now look for functions in the given module, as well as all of user-provided extra modules, and then filter all methods of all the discovered functions by whether they come from the module of interest. A good option is to pass `Base.loaded_modules_array()` as the extra modules argument, as this will return a vector of all the modules loaded currently in the julia session. This includes Base, Core, the module of interest, and all of its transitive dependencies. Any extra modules that also happen to be loaded are processed too, but this doesn't seem to affect performace much. Document the new `extra_modules` feature
|
After I merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #34, but I edited some docs...