Trace type stability checks we do #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when run is_stable_method(m,trace_scfg), you get a text file checks/$m.name with types that were tried when checking type stability
the format is now that of method defn
This makes it easier to run "the whole" test suite with a custom scfg (e.g. for tracing purposes). Note that some tests tailor scfg for their needs, so we don't pass the default `test_scfg` to them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the checks in a
checksfile in the current dir.The tracing mode is governed by a flag in the search config (
SearchCfg). There's a default config with that flag on calledtrace_scfg. So, callingis_stable_method((@which f(1)), trace_cfg)should store the trace in the./checksfile.Currently, the
./checksfile is opened in an append mode so that we can make several calls tois_stable_methodand see all the checks. This has pros and cons in terms of usability...The format of the
./checksfile is funny: its "pseudo method declarations". E.g. if we checkfwith inputInt, we will producefunction f(::Int)in the trace.Perhaps, squash before merge.