Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-vertical initial point and interpolated points to include 'inc' and 'azi' #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

romanshor
Copy link

Proposing small changes:

  • include the ability to have a non-vertical first point (ie, inclined well from surface)
  • added 'inc' and 'azi' to point dictionary for interpolated points in hold and vertical sections
  • updated version to 0.7.4

Copy link
Collaborator

@jcamiloangarita jcamiloangarita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @romanshor for your contribution to this project. All changes seems to be fine, but there's still one 1 test failing (tests/test_well.py/test_get_point). Please check it out and add the respective changes to keep all the tests passing.

Just adding the 'inc' and 'azi' properties to the dictionary solves it.

25| self.assertTrue(p == {'md': 100, 'dl': 0.0, 'north': 0, 'east': 0, 'tvd': 100,
26|                       'inc': 0, 'azi': 0,
27|                       'pointType': 'interpolated', 'sectionType': 'vertical'})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants