Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse value when format has not year (MM-dd) #107

Closed
wants to merge 3 commits into from

Conversation

jorgejaime
Copy link

No description provided.

@probablykasper
Copy link
Owner

probablykasper commented Nov 25, 2024

#106 (comment)

Could you elaborate on the issue? It seems to work fine for me:

Screen.Recording.2024-11-25.at.23.28.01.mp4

I should've mentioned, this screen recording is just from https://date-picker-svelte.kasper.space - not from your PR.

@jorgejaime
Copy link
Author

The issue is when we set the value manually and clean the input. Steps to reproduce: 1. select a value using date picker 2. clean the value manually 3. set the value manually

@probablykasper
Copy link
Owner

Ah I see

@jorgejaime
Copy link
Author

issue.mp4

@jorgejaime
Copy link
Author

@probablykasper is it possible to have this fix this week?

@probablykasper
Copy link
Owner

What you're doing with min causes the user's value to be overridden.

The issue just that it defaults to 2020 when no year is supplied instead of using the current year, right?

@jorgejaime
Copy link
Author

Let say, we have a min date 2020-01-01 and max date 2022-12-31 but current year is 2024. These is the reason I am using min date to set basedate

@probablykasper
Copy link
Owner

I don't really see that making sense for most use cases. I'll make it default to the current year

@probablykasper
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants