Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: All the remaining pubsub message handlers #23

Merged
merged 9 commits into from
May 17, 2024

Conversation

0x00101010
Copy link
Contributor

@0x00101010 0x00101010 commented May 15, 2024

Some example logs:

info  | 18:16:50.613902 | Handling aggregate and proof message      
PeerID=16Uiu2HAmR3653mh9jJrN2QS4VpsQLVHRoBWZge5LZpg5K61rMud9 
MsgID=d564cb1603cac4c70e9daed4b7c9d9c08df6f4d4 
MsgSize=436 
Topic=/eth2/d31f6191/beacon_aggregate_and_proof/ssz_snappy 
Seq=[] 
Sig=0xac12af5739b995f3162cadad4cd65bac64004b08dff2b3c9d790c727fa05163bf74e3a2db0edbb9ab39c1fae40951e11175727fe163938810839c1b8a7b35f477ccc31aae88daaed594c302242e9ebb516a9ac074e9ed07748f97e859426b6f1 
AggIdx=508 
SelectionProof=0xb2801c3ee1fe59b0b4137930a9e585f3d79cef9154de5ef472b6ab272cb76a3bb43b93d28e506f46454e16db65e9d0990560e4fe32e6554bee4b69dc49fd2aceabfa91a76483ec7f6f365e41586fb2c1f75021d38bd3ea39b72be9d8c5a5af95
info  | 18:16:50.613902 | Handling sync committee message           
PeerID=16Uiu2HAkuxvJXUaZrQnwTF5NWv28QPYPUMRYiG2HE6uprBMzNfv2 
MsgID=0192365038b3d4e79ef826ee22b30dd9e95c0c98 
MsgSize=146 
Topic=/eth2/d31f6191/sync_committee_3/ssz_snappy 
Seq=[] 
Slot=5005284 
ValIdx=601 
BlockRoot=0x60a1076e48df0b760f621e149b89720e52fd058250d3c5436ad98d5f67c19c82 
Signature=0xb9d46988371bd13d9ca6a1726991491ecd4c684315cf2e151a36afcc8e641a06e42e9177680494b28e4969cb3e3fbe70034e180606ef943cbf92e6ce92b71043943ad5ef675b11ab1943b5988291b04cf76e93e16abf4ca39a5cd28a6698
info  | 17:26:16.330068 | Handling attestation gossip message 
PeerID=16Uiu2HAm2ip3wstWCRT7bfagDUxfXM1KGy3HXu9r7cGnjCJGDS9x 
RemotePeerID=16Uiu2HAm1smC4eM6NQ8sN5m4AccRZuByFmbhU9WxV28rGmSQ6WJM 
MsgID=6d272729045ada8e5c0b79499bd916f99ae5f4fa 
MsgSize=226 
Topic=/eth2/d31f6191/beacon_attestation_7/ssz_snappy 
Seq=[] 
CommIdx=0 
Slot=5005031

@0x00101010 0x00101010 marked this pull request as ready for review May 15, 2024 23:23
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 238 lines in your changes are missing coverage. Please review.

Project coverage is 2.95%. Comparing base (b94d32c) to head (66b1d87).
Report is 87 commits behind head on main.

Files Patch % Lines
eth/pubsub.go 0.00% 233 Missing ⚠️
eth/node_config.go 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #23      +/-   ##
========================================
- Coverage   7.75%   2.95%   -4.80%     
========================================
  Files          7      26      +19     
  Lines        400    3751    +3351     
========================================
+ Hits          31     111      +80     
- Misses       361    3629    +3268     
- Partials       8      11       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eth/pubsub.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cortze cortze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks again @0x00101010 for taking care of this!

@0x00101010
Copy link
Contributor Author

0x00101010 commented May 16, 2024

Looks good to me! Thanks again @0x00101010 for taking care of this!

Thank you @cortze, can you help merge both PRs?

Copy link
Contributor

@guillaumemichel guillaumemichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guillaumemichel guillaumemichel merged commit e362cd6 into probe-lab:main May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants