-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate the 404 page using React on the frontend. #2168
base: develop
Are you sure you want to change the base?
Generate the 404 page using React on the frontend. #2168
Conversation
@raclim I've got this to a point where it's working and I feel that it's a major improvement. Let me now if you have any questions about the code or any other feedback. We will eventually want to add translations of the 404 page text for all languages. There are some minor TODOs remaining. |
…d-404 # Conflicts: # client/routes.jsx
@raclim I removed the refactoring of |
ugh I need to fix the import of the |
Thanks so much for keeping up and working on all of these different components and changes so far! |
…d-404 # Conflicts: # client/modules/Preview/EmbedFrame.jsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely Done 👍
Fixes #2159
Fixes #2256
Done:
EmbedFrame
component.EmbedFrame
code for sending errors to the IDE console from when it is used on the 404 page (via a newsendMessages
prop).react-router
route to show the 404 page when no route matches.renderIndex()
content with a 404 status.Cleanup server "object exists" checks withasync
/await
syntax.window.__SERVER_404__
from server to client.To Do:
textOutput
gridOutput
andbasePath
props.I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123