Cleanup getProjectsForUser
function
#2320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on issue #521
Changes:
getProjectsForUser
(internal API) andapiGetProjectsForUser
(public API).async
/await
syntax.req.params.username
instead of returning an empty array.Note: there is a lot of discussion in PR #973 about wrapping an entire Express handler in a
try
/catch
like I am doing here and whether there are better alternatives. We may want to revisit this as I'm not sure what the current best practice is.I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123