Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Translation of "Web editor" #2330

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

adityagarg06
Copy link
Contributor

Fixes #2322

Changes:
I have changed the translation of the "web editor" in the translation.json files of the following languages: it, ja, uk-UA, zh-TW.
De has the same translation as In English, so I didn't change that.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

I think I'm still not completely sure about the best way to handle this, but since "p5.js Web Editor" has been translated into several languages already I'm down to have this in for now!

@raclim raclim merged commit d13060e into processing:develop Jan 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about translations: should we translate the words "Web Editor"?
3 participants