Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The complete Korean language translation of keyboard shortcuts #2331

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

sdivyanshu90
Copy link
Contributor

@sdivyanshu90 sdivyanshu90 commented Jul 27, 2023

Fixes: Keyboard Shortcuts

  • I have noticed that the Korean translation of the keyboard shortcut is not complete.
  • It can be confusing and frustrating when trying to use certain keyboard shortcuts because some of the key labels are still in English.
image

Changes:

  • I have translated the keyboard shortcuts into the Korean language.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.

@sdivyanshu90
Copy link
Contributor Author

Hi @lindapaiste, could you review my pull request and provide feedback? Thanks!

@lindapaiste
Copy link
Collaborator

@sdivyanshu90 the PR looks good 👍🏻

Hopefully someone who knows Korean can check it over and verify that the translations are correct.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great start! The translations mostly seem fine to me, but some of the word choices might not make sense in a coding environment. I would update some of them in the lines I noted!

My suggested changes might not be perfect though, so open to input from others as well!

translations/locales/ko/translations.json Outdated Show resolved Hide resolved
translations/locales/ko/translations.json Outdated Show resolved Hide resolved
translations/locales/ko/translations.json Outdated Show resolved Hide resolved
translations/locales/ko/translations.json Outdated Show resolved Hide resolved
translations/locales/ko/translations.json Outdated Show resolved Hide resolved
translations/locales/ko/translations.json Outdated Show resolved Hide resolved
translations/locales/ko/translations.json Outdated Show resolved Hide resolved
translations/locales/ko/translations.json Outdated Show resolved Hide resolved
translations/locales/ko/translations.json Outdated Show resolved Hide resolved
translations/locales/ko/translations.json Show resolved Hide resolved
@sdivyanshu90
Copy link
Contributor Author

sdivyanshu90 commented Aug 5, 2023

Thank you for your review, @raclim and @yinhwa! I've implemented all the mentioned changes.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much for your work on this!

@raclim raclim merged commit b5ecd60 into processing:develop Aug 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants