-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The complete Korean language translation of keyboard shortcuts #2331
Conversation
Hi @lindapaiste, could you review my pull request and provide feedback? Thanks! |
@sdivyanshu90 the PR looks good 👍🏻 Hopefully someone who knows Korean can check it over and verify that the translations are correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great start! The translations mostly seem fine to me, but some of the word choices might not make sense in a coding environment. I would update some of them in the lines I noted!
My suggested changes might not be perfect though, so open to input from others as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks so much for your work on this!
Fixes: Keyboard Shortcuts
Changes:
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.