Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2338 sidebar dropdown stays open after sidebar is closed #2339

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix #2338 sidebar dropdown stays open after sidebar is closed #2339

merged 1 commit into from
Jul 31, 2023

Conversation

mohamedaleya
Copy link
Contributor

@mohamedaleya mohamedaleya commented Jul 31, 2023 •
edited
Loading

Fixes #2338 sidebar dropdown stays open after sidebar is closed

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Jul 31, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

lindapaiste
lindapaiste approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

There are a few other places where it could potentially be handled and I'm currently resisting the urge to overthink which is "best" because this will definitely solve the problem ✔️

@lindapaiste lindapaiste merged commit 7b71ad7 into processing:develop Jul 31, 2023
1 check passed
@lindapaiste
Copy link
Collaborator

@all-contributors please add @mohamedaleya for code

@mohamedaleya mohamedaleya deleted the fix-ide-project-options-not-collapsing branch July 31, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindapaiste lindapaiste lindapaiste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar dropdown stays open after sidebar is closed
2 participants
@mohamedaleya @lindapaiste